Fix list of core cache warmers #10853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
added
DependencyInjection
Status: Reviewed
and removed
Status: Needs Review
labels
javiereguiluz
added a commit
that referenced
this pull request
Jan 9, 2019
This PR was merged into the 3.4 branch. Discussion ---------- Fix list of core cache warmers Currently there are many core cache warmers missing in the documentation: ```bash Symfony Container Services Tagged with "kernel.cache_warmer" Tag ================================================================ ----------------------------------------------------- ---------- ----------------------------------------------------------------------- Service ID priority Class name ----------------------------------------------------- ---------- ----------------------------------------------------------------------- annotations.cache_warmer Symfony\Bundle\FrameworkBundle\CacheWarmer\AnnotationsCacheWarmer doctrine.orm.proxy_cache_warmer Symfony\Bridge\Doctrine\CacheWarmer\ProxyCacheWarmer router.cache_warmer Symfony\Bundle\FrameworkBundle\CacheWarmer\RouterCacheWarmer serializer.mapping.cache_warmer Symfony\Bundle\FrameworkBundle\CacheWarmer\SerializerCacheWarmer templating.cache_warmer.template_paths 20 Symfony\Bundle\FrameworkBundle\CacheWarmer\TemplatePathsCacheWarmer translation.warmer Symfony\Bundle\FrameworkBundle\CacheWarmer\TranslationsCacheWarmer twig.cache_warmer Symfony\Bundle\TwigBundle\CacheWarmer\TemplateCacheCacheWarmer twig.template_cache_warmer Symfony\Bundle\TwigBundle\CacheWarmer\TemplateCacheWarmer validator.mapping.cache_warmer Symfony\Bundle\FrameworkBundle\CacheWarmer\ValidatorCacheWarmer ----------------------------------------------------- ---------- ----------------------------------------------------------------------- ``` Commits ------- 1f5fc2a Fix list of core cache warmers
|
@alexander-schranz thanks for this contribution. Sadly, solving this is more complicated than it looks in modern Symfony versions. Since apps are now much more modular, the list of warmers depends on the components/bundles you pick. For example, my list of warmers for the Symfony Demo app is different that the list you showed here: $ php bin/console debug:container --tag=kernel.cache_warmer
Symfony Container Services Tagged with "kernel.cache_warmer" Tag
================================================================
--------------------------------- --------------------------------------------------------------------
Service ID Class name
--------------------------------- --------------------------------------------------------------------
annotations.cache_warmer Symfony\Bundle\FrameworkBundle\CacheWarmer\AnnotationsCacheWarmer
doctrine.orm.proxy_cache_warmer Symfony\Bridge\Doctrine\CacheWarmer\ProxyCacheWarmer
router.cache_warmer Symfony\Bundle\FrameworkBundle\CacheWarmer\RouterCacheWarmer
translation.warmer Symfony\Bundle\FrameworkBundle\CacheWarmer\TranslationsCacheWarmer
twig.cache_warmer Symfony\Bundle\TwigBundle\CacheWarmer\TemplateCacheCacheWarmer
twig.template_cache_warmer Symfony\Bundle\TwigBundle\CacheWarmer\TemplateCacheWarmer
validator.mapping.cache_warmer Symfony\Bundle\FrameworkBundle\CacheWarmer\ValidatorCacheWarmer
--------------------------------- --------------------------------------------------------------------So, to avoid confusion and to make docs easier to maintain, I've merged your PR but, after that, I've replaced in 8953c9d the table of cache warmers with the Thanks for understanding! |
|
@javiereguiluz sounds reasonable did stumble over this because of a symfony certification question in the university where |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are many core cache warmers missing in the documentation: